BC-5119-Prevent-creating-new-neXboards (Server) #4522

Michaellinaresxk · 2023-11-05T20:19:33Z

Description

This is the server implementation to exclude nexboard when user try to copy and share courses.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5119
hpi-schul-cloud/schulcloud-client#3313

Changes

I removed the nextBoard in the copy course process.

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
QA: In addition to review, the code has been manually tested (if manual testing is possible)
All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

apps/server/src/modules/learnroom/controller/rooms.controller.ts

… to ignore LESSON_CONTENT_NEXBOARD.

bn-pass

I think you've missed very important place, which also has some flag to turn on/off copying of the Nexboard, but it's using the general flag for enabling/disabling the Nexboard (which has to stay enabled as we still want to keep the existing Nexboards usable). Please take a look here:

schulcloud-server/apps/server/src/modules/lesson/service/lesson-copy.service.ts

Line 230 in fc68ac0

if (element.component === ComponentType.NEXBOARD && nexboardEnabled) {

. Probably you'll have to modify it to use another flag to just disable/enable only the copying of the Nexboards, not the whole Nexboard functionality.

apps/server/src/modules/learnroom/service/course-copy.service.ts

bn-pass · 2023-11-17T09:16:02Z

.vscode/launch.default.json

Please revert these changes.

bn-pass · 2023-11-17T09:16:07Z

.vscode/settings.default.json

Please revert these changes.

apps/server/src/modules/learnroom/controller/rooms.controller.ts

bn-pass · 2023-11-17T09:17:11Z

apps/server/src/modules/learnroom/service/board-copy.service.ts

Please remember to use prettier.

apps/server/src/modules/lesson/service/lesson-copy.service.ts

virgilchiriac

pls cleanup (see also the linter test)
I am not sure if this is the most elegant way... Rather than delete code and such, I would introduce a feature flag just for the nexboard copy. Perhaps we will need nexboard back in the near future, or some instances will change their mind and will want to keep it including the copying...

virgilchiriac · 2023-11-17T18:42:35Z

apps/server/src/modules/learnroom/service/board-copy.service.ts

revert formating changes on this file

apps/server/src/modules/lesson/service/lesson-copy.service.ts

sonarqubecloud · 2023-11-20T09:19:26Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

apps/server/src/modules/lesson/service/lesson-copy.service.ts

virgilchiriac

plus some cleanup still needs to happen
the .vscode folder should not be chnged
the .DS_Store files - you don't need to touch those

virgilchiriac · 2023-11-20T19:42:59Z

.vscode/launch.default.json

restore the file

virgilchiriac · 2023-11-20T19:43:07Z

.vscode/settings.default.json

restore the file

virgilchiriac · 2023-11-20T19:48:27Z

apps/server/src/modules/learnroom/service/course-copy.service.ts

@@ -46,13 +46,23 @@ export class CourseCopyService {
 		// copy course and board
 		const courseCopy = await this.copyCourseEntity({ user, originalCourse, copyName });
 		const boardStatus = await this.boardCopyService.copyBoard({ originalBoard, destinationCourse: courseCopy, user });
+		const filteredBoardStatus = this.filterOutNeXboardFromCopyStatus(boardStatus);


here too should use the new feature flag condition...

virgilchiriac · 2023-11-20T19:48:43Z

src/services/.DS_Store

restore file

virgilchiriac · 2023-11-20T19:48:50Z

src/services/fileStorage/.DS_Store

restore file

virgilchiriac · 2023-11-20T19:55:56Z

apps/server/src/modules/lesson/service/lesson-copy.service.ts

@@ -227,7 +228,7 @@ export class LessonCopyService {
 				copiedContent.push(linkContent);
 				copiedContentStatus.push(embeddedTaskStatus);
 			}
-			if (element.component === ComponentType.NEXBOARD && nexboardEnabled) {
+			if (element.component === ComponentType.NEXBOARD && nexboardEnabled && copyNexboardEnabled) {


the previous solution with status NOT_DOING was better
so, why not applying the condition just at that level instead of skiping the who thing?
the correct behaviour is to inform the client that nexboard is not copied (on purpose).

Created functionality to ignore copy nextboard.

0446d19

Michaellinaresxk added the WIP This feature branch is in progress, do not merge into master. label Nov 5, 2023

removing console.logs

62b0698

Michaellinaresxk changed the title ~~Created functionality to ignore copy nextboard.~~ BC-5119-Prevent-creating-new-neXboards (Server) Nov 5, 2023

Michaellinaresxk added 3 commits November 6, 2023 12:44

test

8117254

test

0d2022f

testing spaces.

897036c

bn-pass suggested changes Nov 13, 2023

View reviewed changes

apps/server/src/modules/learnroom/controller/rooms.controller.ts Outdated Show resolved Hide resolved

Added private filterOutNeXboardFromCopyStatus to copy course function…

99428b9

… to ignore LESSON_CONTENT_NEXBOARD.

Michaellinaresxk force-pushed the BC-5119-Prevent-creating-new-neXboards branch from 0049531 to 99428b9 Compare November 14, 2023 12:58

bn-pass suggested changes Nov 14, 2023

View reviewed changes

apps/server/src/modules/learnroom/service/course-copy.service.ts Outdated Show resolved Hide resolved

apps/server/src/modules/learnroom/service/course-copy.service.ts Show resolved Hide resolved

Michaellinaresxk added 3 commits November 14, 2023 14:22

test

c7886f0

BC-5119-Prevent-creating-new-neXboards

98a4993

remove the commented code.

23027d4

Michaellinaresxk force-pushed the BC-5119-Prevent-creating-new-neXboards branch 2 times, most recently from 53c0136 to 23027d4 Compare November 16, 2023 21:12

bn-pass suggested changes Nov 17, 2023

View reviewed changes

Changed the lesson copy service behaviour.

8a4c7ed

Michaellinaresxk force-pushed the BC-5119-Prevent-creating-new-neXboards branch from fe8e6cb to 8a4c7ed Compare November 17, 2023 11:23

virgilchiriac requested changes Nov 17, 2023

View reviewed changes

virgilchiriac mentioned this pull request Nov 17, 2023

BC-5119-Prevent create new neXboard (Front) hpi-schul-cloud/schulcloud-client#3313

Merged

3 tasks

Michaellinaresxk removed the WIP This feature branch is in progress, do not merge into master. label Nov 19, 2023

Identation fixed.

8c51e64

Michaellinaresxk force-pushed the BC-5119-Prevent-creating-new-neXboards branch from b4f7300 to 8c51e64 Compare November 19, 2023 20:53

Added FEATURE_COPY_NEXBOARD_ENABLED to cenabled nexboard on copy course.

1faba72

Michaellinaresxk force-pushed the BC-5119-Prevent-creating-new-neXboards branch from e65731b to 1faba72 Compare November 20, 2023 10:34

Michaellinaresxk requested review from virgilchiriac and bn-pass November 20, 2023 10:35

virgilchiriac approved these changes Nov 20, 2023

View reviewed changes

apps/server/src/modules/lesson/service/lesson-copy.service.ts Show resolved Hide resolved

virgilchiriac requested changes Nov 20, 2023

View reviewed changes

Added FEATURE_COPY_NEXBOARD_ENABLED to cenabled nexboard on copy course.

e99e428

Michaellinaresxk force-pushed the BC-5119-Prevent-creating-new-neXboards branch from 195c5bc to e99e428 Compare November 20, 2023 12:00

virgilchiriac requested changes Nov 20, 2023

View reviewed changes

DS_Store file restored.

5db47fd

Michaellinaresxk force-pushed the BC-5119-Prevent-creating-new-neXboards branch from 93914c2 to 5db47fd Compare November 21, 2023 09:17

Michaellinaresxk added 2 commits November 21, 2023 10:20

File fileStorage-DS_storage restored.

2a4ffd7

add NOT_DOIN enum.

b19394d

Michaellinaresxk closed this Nov 23, 2023

davwas deleted the BC-5119-Prevent-creating-new-neXboards branch December 8, 2023 11:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BC-5119-Prevent-creating-new-neXboards (Server) #4522

BC-5119-Prevent-creating-new-neXboards (Server) #4522

Michaellinaresxk commented Nov 5, 2023 •

edited

Loading

bn-pass left a comment

bn-pass Nov 17, 2023

bn-pass Nov 17, 2023

bn-pass Nov 17, 2023

virgilchiriac left a comment

virgilchiriac Nov 17, 2023

sonarqubecloud bot commented Nov 20, 2023

virgilchiriac left a comment

virgilchiriac Nov 20, 2023

virgilchiriac Nov 20, 2023

virgilchiriac Nov 20, 2023

virgilchiriac Nov 20, 2023

virgilchiriac Nov 20, 2023

virgilchiriac Nov 20, 2023

BC-5119-Prevent-creating-new-neXboards (Server) #4522

BC-5119-Prevent-creating-new-neXboards (Server) #4522

Conversation

Michaellinaresxk commented Nov 5, 2023 • edited Loading

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

bn-pass left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

virgilchiriac left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 20, 2023

virgilchiriac left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Michaellinaresxk commented Nov 5, 2023 •

edited

Loading